The Last Homely House

General => The Golden Hall => Topic started by: Kralik on July 09, 2020, 09:31:43 PM

Title: WHAT HAPPENED?!
Post by: Kralik on July 09, 2020, 09:31:43 PM
 :o :o :o :o :o :o

Welcome to the upgraded forums! Sadly we lost the old theme but this was the closest one I could find. Here's are some of the things that aren't working yet:

* Card autolinks
* Card previews
* Email notifications
* Set selection header
* Favorite formats in player profiles
* Gold counts and voting posts up/down
* Probably lots of other things I forgot about

In addition since the Wiki login system was tied to the old forum accounts, the Wiki won't be editable for now.

I'll be plugging away at it here and there within the next few weeks (hopefully). It's been a loooooooong while since I did this stuff so I'll have to jog my memory. Registration is using a new, simple anti-bot measure for now. If we get a sudden influx of spammers, please email or PM me right away so I can tweak it manually with a trivia question.

What else is broken or missing? Post it here!
Title: Re: WHAT HAPPENED?!
Post by: TelTura on July 09, 2020, 10:08:56 PM
The "New" tag put on the end of threads with new posts doesn't use a different style, so it looks like part of the thread title:

(https://i.imgur.com/lptXNgp.png)

Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 09, 2020, 10:32:04 PM
The "New" tag put on the end of threads with new posts doesn't use a different style, so it looks like part of the thread title:

(https://i.imgur.com/lptXNgp.png)


Thanks! Easy fix. I'll probably have to make a number of manual tweaks to the theme--I have already and I wouldn't be surprised if there are more.
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 10, 2020, 11:38:01 AM
Registration is using a new, simple anti-bot measure for now. If we get a sudden influx of spammers, please email or PM me right away so I can tweak it manually with a trivia question.

OK, we already got one spammer so I changed the question. Should be very easy for a human to answer but hopefully no bots. If course, what if we are ALL bots and we don't even know it? GASP
Title: Re: WHAT HAPPENED?!
Post by: menace64 on July 10, 2020, 07:34:48 PM
what if we are ALL bots and we don't even know it? GASP

I poop, therefore I am.
Title: Re: WHAT HAPPENED?!
Post by: TelTura on July 11, 2020, 07:20:07 AM
Wellp, that's two more spam post replies, so what's there is clearly not working.

EDIT TEST
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 11, 2020, 04:14:06 PM
Wellp, that's two more spam post replies, so what's there is clearly not working.

Thanks for letting me know. I removed the hint and made an additional tweak or two. Let's see if that helps.
Title: Re: WHAT HAPPENED?!
Post by: Durin's Heir on July 12, 2020, 09:07:09 AM
Short edit of posts doesn't work. When trying to save the edition, says "The message body was left empty."

Special smileys (like [Ring], [6] or [Dunland]) are unaligned with the text.
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 12, 2020, 10:54:03 AM
Short edit of posts doesn't work. When trying to save the edition, says "The message body was left empty."

Special smileys (like [Ring], [6] or [Dunland]) are unaligned with the text.

Can you clarify what you mean by short edit?

I can see the smileys you mentioned are slightly lower than the text--is that what you are referring to?
Title: Re: WHAT HAPPENED?!
Post by: Durin's Heir on July 12, 2020, 01:04:41 PM
Can you clarify what you mean by short edit?
The edit made to a post without moving to another page. The one that's accessed with the button at the lower right corner of the post.

I can see the smileys you mentioned are slightly lower than the text--is that what you are referring to?
Yes, exactly that.
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 12, 2020, 08:37:58 PM
The edit made to a post without moving to another page. The one that's accessed with the button at the lower right corner of the post.

Strange, it's working fine for me. Is it possible it's a browser issue? Can anyone else confirm?
Title: Re: WHAT HAPPENED?!
Post by: TelTura on July 12, 2020, 09:04:46 PM
Yeah, I just edited my comment above using that functionality.  Worked fine for me on Firefox using Windows 10.
Title: Re: WHAT HAPPENED?!
Post by: Durin's Heir on July 12, 2020, 09:19:54 PM
Yeah, I just edited my comment above using that functionality.  Worked fine for me on Firefox using Windows 10.
Well, it actually works well with my posts in this thread, which are short. But didn't (and still doesn't) work when trying to modify this much longer post. (https://lotrtcgwiki.com/forums/index.php?topic=11735.msg96739#msg96739) So perhaps it's about length.

Opera, Win 10 64bits.
Title: Re: WHAT HAPPENED?!
Post by: TelTura on July 12, 2020, 10:34:19 PM
If it is, it's a specific length.  I just in-place edited the much longer OP in this thread with no problems: https://lotrtcgwiki.com/forums/index.php?topic=11718.0
Title: Re: WHAT HAPPENED?!
Post by: Dictionary on July 13, 2020, 03:21:13 AM
I had the same issue as Durin's Heir trying to edit my recent long thread here: https://lotrtcgwiki.com/forums/index.php?topic=11731.0

I could edit it fine using "Modify" at the top, but not when using the icon at the bottom.
Title: Re: WHAT HAPPENED?!
Post by: TelTura on July 14, 2020, 01:24:47 AM
The navigation bar at the top of the screen is missing, which makes hopping back and forth between here and the wiki a bit more obnoxious.
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 14, 2020, 12:43:21 PM
The navigation bar at the top of the screen is missing, which makes hopping back and forth between here and the wiki a bit more obnoxious.

Yeah, that was a manual tweak of the previous theme. On my todo list.

Current plans are to work on the Wiki a bit and then come back to work on forum issues after that.
Title: Re: WHAT HAPPENED?!
Post by: ket_the_jet on July 15, 2020, 01:53:22 PM
Search button seems to work, so you'll hear no complaints from me.
-wtk
Title: Re: WHAT HAPPENED?!
Post by: Durin's Heir on July 18, 2020, 11:30:25 PM
Culture icon smileys now need initial caps: [gandalf] no longer is equal to [Gandalf].

Also, manual link to a card via "add text here" does not work anymore.
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 20, 2020, 09:42:55 AM
Culture icon smileys now need initial caps: [gandalf] no longer is equal to [Gandalf].

Also, manual link to a card via "add text here" does not work anymore.

Autolinks in general are broken, and it will take some time before I can get to fixing that. Looks like I'll have to tweak the code for smileys as well...
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 24, 2020, 04:31:06 PM
Culture icon smileys now need initial caps: [gandalf] no longer is equal to [Gandalf].

Also, manual link to a card via "add text here" does not work anymore.

Both should now be fixed! Autolinks are working again.
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 24, 2020, 04:39:10 PM
Autolink card images are now showing full sized instead of a user-configurable option. The rationale behind the smaller size configuration was to save bandwidth and to accommodate lower resolutions. Both should be non-issues now and it's simpler for me not to bother adding that extra setting. :mrgreen:
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 24, 2020, 04:41:50 PM
Special smileys (like [Ring], [6] or [Dunland]) are unaligned with the text.

Looks like this was a style affecting all smileys. I changed the vertical align... does it look better to you now?
Title: Re: WHAT HAPPENED?!
Post by: Durin's Heir on July 25, 2020, 12:21:39 AM
Great, thanks! The alignment is now better but still not optimal, the difference is easier to notice in the card title of text Dream Cards (with twilight cost at one side and culture at the other), like this one for instance. (https://lotrtcgwiki.com/forums/index.php?topic=124.msg96337#msg96337) Everything else is perfect!


In the name of every hermitic LOTR TCG fan with creative impulses, THANK YOU FOR THIS SITE, MAN!   ;)
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 25, 2020, 09:17:22 AM
It's tricky making them line up perfectly as different smileys display have different vertical aligns and font size is a factor. I moved it down ~8%. Take a look:

[3] Banned [Sauron]
[1] •Mellon! [Shire]

Better?
Title: Re: WHAT HAPPENED?!
Post by: menace64 on July 25, 2020, 01:57:12 PM
I’m unsure if I got to see what 0% realignment looked like, but -8% looks rather janky.

It might be more trouble than it’s worth (ultimately, we can still read them and we’ll surely adjust eventually), but could you throw together a slide comparing different +/- alignments? Then we could see them all at once.
Title: Re: WHAT HAPPENED?!
Post by: Kralik on July 26, 2020, 10:57:12 AM
It might be more trouble than it’s worth (ultimately, we can still read them and we’ll surely adjust eventually), but could you throw together a slide comparing different +/- alignments? Then we could see them all at once.

Unfortunately, no. It's a global CSS setting for all smileys. On my screen -8% looks about perfect other than the [Sauron] symbol... maybe I should just leave it at the default alignment and call it good.
Title: Re: WHAT HAPPENED?!
Post by: menace64 on July 26, 2020, 11:13:36 AM
I hadn't considered that each screen would resolve the icons differently. That does make it peskily difficult to find a happy medium.

But whatever you did between yesterday and today has made the icons align pretty well with the text.

I Am Minion [dunland] [Gollum] [isengard] [Men] [moria] [orc] [raider] [sauron] [uruk] [wraith]
Minion

Yeah those all look just fine to me!
Title: Re: WHAT HAPPENED?!
Post by: Phallen Cassidy on July 30, 2020, 02:20:14 PM
Game replay links cut off at the $ now. Here's one of me losing to Ferny Frost the other day: http://www.gempukku.com/gemp-lotr/game.html?replayId=Phallen$idy6iaxfttmkndpk

EDIT: why would that one work when this one doesn't?  www.gempukku.com/gemp-lotr/game.html?replayId=Phallen$r6m2j766wt7nwae0
Title: Re: WHAT HAPPENED?!
Post by: TelTura on July 30, 2020, 02:26:48 PM
http://www.gempukku.com/gemp-lotr/game.html?replayId=Phallen$idy6iaxfttmkndpk

www.gempukku.com/gemp-lotr/game.html?replayId=Phallen$r6m2j766wt7nwae0
http://www.gempukku.com/gemp-lotr/game.html?replayId=Phallen$r6m2j766wt7nwae0



Looks like it's the http:// at the beginning that clues the parser in. 
Title: Re: WHAT HAPPENED?!
Post by: Phallen Cassidy on August 24, 2020, 06:09:57 AM
The icons in the wiki are lower quality than the ones in the forums. E.g.: https://lotrtcgwiki.com/wiki/culture
Title: Re: WHAT HAPPENED?!
Post by: TelTura on August 24, 2020, 06:35:23 AM
The ones on the wiki are my fault; I attempted some time ago to do some image processing to get them to read better.

(Also, I'm affronted that someone perceives the quality to be that different.  They're aliased differently, that's for sure, but they also have less yellow smearing of details.  The biggest issue is that they're not the same size and so didn't translate perfectly in-place.)

Anyway.  That's not an issue with the upgrade, and will be addressed with the new wiki anyhow.
Title: Re: WHAT HAPPENED?!
Post by: Durin's Heir on August 24, 2020, 09:06:33 AM
After using the in-page edit, the system replaces the unique dot  "•" with "%u2022". Which often forces me to use the upper-right "Modify" button (to either avoid the conversion in first place, or to correct it if already done).
Title: Re: WHAT HAPPENED?!
Post by: Phallen Cassidy on August 24, 2020, 05:37:01 PM
(Also, I'm affronted that someone perceives the quality to be that different.  They're aliased differently, that's for sure, but they also have less yellow smearing of details.  The biggest issue is that they're not the same size and so didn't translate perfectly in-place.)

Oh, I thought they might've been a result of the icon tinkering Kralik was doing. I don't remember them looking this way before the switch, anyway. Some of them aren't even noticeable, but Men, Shire, and Isengard really stand out without any anti-aliasing. Might be an issue on my screen alone?
Title: Re: WHAT HAPPENED?!
Post by: JamesCB on September 30, 2020, 07:28:15 AM
Quote
Might be an issue on my screen alone?
Nah, I see it on Men, Shire, Isengard, and even Dwarven.
Title: Re: WHAT HAPPENED?!
Post by: TelTura on December 02, 2020, 07:23:18 AM
Dunno if something new has been altered, but the forum is now automatically replacing underscores with spaces in hyperlinks: https://github.com/ketura/LotR-TCG_card_generator/releases/tag/v1.9.1.

It hasn't always done this (else no one would ever have been able to download my generator), but has happened sometime in the last couple weeks.
Title: Re: WHAT HAPPENED?!
Post by: TelTura on December 02, 2020, 07:29:07 AM
...huh. It didn't do it above, but it is certainly doing so in my generator thread: https://lotrtcgwiki.com/forums/index.php?topic=11718.0

Even the links that look fine are replacing _ with %20 in the IRL.