LotR TCG Wiki → Card Sets:  All 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 → Forums:  TLHH CC

Author Topic: Wiki Improvement Suggestion Thread  (Read 6815 times)

0 Members and 1 Guest are viewing this topic.

May 17, 2012, 02:10:39 PM
Reply #30

Kralik

  • Guest
Re: Wiki Improvement Suggestion Thread
« Reply #30 on: May 17, 2012, 02:10:39 PM »
Certainly other people besides TelTura and I need to be editing the wiki -- so take your best shots! Maybe I'll start throwing around some slanderous stuff to rile people up.

"...Cirdan... possibly the most useless addition to [Elven] strategy since Lorien Elf..."

May 18, 2012, 04:40:49 PM
Reply #31

TelTura

  • *****
  • Information Offline
  • Ranger
  • Administrator
  • Posts: 812
    • Player's Council Discord
Re: Wiki Improvement Suggestion Thread
« Reply #31 on: May 18, 2012, 04:40:49 PM »
1U162 has some issue with the autolinker; it's inserting an extra *

[EDIT:] Same with 4R52
« Last Edit: May 18, 2012, 05:40:23 PM by TelTura »
Come join the Player's Council to help us run events, create new cards, and steer the direction of this great game!

Join our Discord here for more information.

May 18, 2012, 06:38:24 PM
Reply #32

Kralik

  • Guest
Re: Wiki Improvement Suggestion Thread
« Reply #32 on: May 18, 2012, 06:38:24 PM »
I'm not seeing it; I've tried searching the page for the * character as well. Where is the problem?

May 18, 2012, 06:48:11 PM
Reply #33

ket_the_jet

  • *****
  • Information Offline
  • King
  • Administrator
  • Posts: 2062
  • He/Him/His
Re: Wiki Improvement Suggestion Thread
« Reply #33 on: May 18, 2012, 06:48:11 PM »
"...Cirdan... possibly the most useless addition to [Elven] strategy since Lorien Elf..."
From an "addition to the game" standpoint, this wouldn't be completely inaccurate.
-wtk

May 18, 2012, 07:52:42 PM
Reply #34

TelTura

  • *****
  • Information Offline
  • Ranger
  • Administrator
  • Posts: 812
    • Player's Council Discord
Re: Wiki Improvement Suggestion Thread
« Reply #34 on: May 18, 2012, 07:52:42 PM »
I'm not seeing it; I've tried searching the page for the * character as well. Where is the problem?

I put up a temp page at errortest showing the problem.

Text:  

**1U162**

**My Axe is Notched**

**6R109**

As you can see, it's inserting an extra * into the title of the link.  Both the first cards are unique; it's possible the star is a holdover for that somewhere.
« Last Edit: May 18, 2012, 08:37:21 PM by TelTura »
Come join the Player's Council to help us run events, create new cards, and steer the direction of this great game!

Join our Discord here for more information.

May 18, 2012, 08:40:14 PM
Reply #35

TelTura

  • *****
  • Information Offline
  • Ranger
  • Administrator
  • Posts: 812
    • Player's Council Discord
Re: Wiki Improvement Suggestion Thread
« Reply #35 on: May 18, 2012, 08:40:14 PM »
Also, you may want to go ahead and remove "box" from the autolinker.  One card causing so many misfires is just a headache.
Come join the Player's Council to help us run events, create new cards, and steer the direction of this great game!

Join our Discord here for more information.

May 19, 2012, 01:49:38 PM
Reply #36

Kralik

  • Guest
Re: Wiki Improvement Suggestion Thread
« Reply #36 on: May 19, 2012, 01:49:38 PM »
I'll remove box -- I thought I had before.

As for the others, I know the problem, and it is very simple: The autolink code parses *'s in the beginning of a card title as the unique dot, as some deck programs (SdA, maybe? Don't remember which) use them as such. Since the * is included in the card title when it links, the normal wiki markup of bold is lost. But... is there a particular reason one needs to bold card titles?

May 19, 2012, 02:18:58 PM
Reply #37

TelTura

  • *****
  • Information Offline
  • Ranger
  • Administrator
  • Posts: 812
    • Player's Council Discord
Re: Wiki Improvement Suggestion Thread
« Reply #37 on: May 19, 2012, 02:18:58 PM »
I'll remove box -- I thought I had before.

As for the others, I know the problem, and it is very simple: The autolink code parses *'s in the beginning of a card title as the unique dot, as some deck programs (SdA, maybe? Don't remember which) use them as such. Since the * is included in the card title when it links, the normal wiki markup of bold is lost. But... is there a particular reason one needs to bold card titles?

the comprehensive rules has sections that are card titles and so are used as section references("See ruling on **My Axe is Notched**")...but it's also sticking the * in for the collector's info autolinker, which shouldn't be there anyway.
Come join the Player's Council to help us run events, create new cards, and steer the direction of this great game!

Join our Discord here for more information.

May 19, 2012, 07:04:43 PM
Reply #38

Kralik

  • Guest
Re: Wiki Improvement Suggestion Thread
« Reply #38 on: May 19, 2012, 07:04:43 PM »
Please give me a direct link to where you are seeing the issue. Are the *'s in the original text, or did you add them for some reason? All of the "rulings" information is in the card database already--at least, for the newest CRD. I'd have to go through the recently unearthed ones to see if there's anything I missed.

The collector's info is handled the same way as the card titles. Each card has one long line that handles the various shortened versions of the card, acronyms, etc. Examples:

*Pippin, Wearer of Black and Silver
Pippin, Wearer of Black and Silver
Pippin Wearer of Black and Silver
Wearer of Black and Silver
Pippin WoBaS
Pippin, WOBAS
woBAS
7R324

It would be a major pain to split the regex.

EDIT: OK, I see now what you've done with comprehensive rules 4-0. Do the card titles really need to be bold? They will stand out as links anyway. I suppose depending on how picky you wish to be you could do the collectors info the same way Decipher does... with spaces. Like: 7 R 324.
« Last Edit: May 19, 2012, 07:14:57 PM by Kralik »

May 19, 2012, 07:34:00 PM
Reply #39

TelTura

  • *****
  • Information Offline
  • Ranger
  • Administrator
  • Posts: 812
    • Player's Council Discord
Re: Wiki Improvement Suggestion Thread
« Reply #39 on: May 19, 2012, 07:34:00 PM »

I put up a temp page at errortest showing the problem.


and 6R109 isn't even unique...
« Last Edit: May 19, 2012, 07:35:32 PM by TelTura »
Come join the Player's Council to help us run events, create new cards, and steer the direction of this great game!

Join our Discord here for more information.

May 20, 2012, 12:11:15 AM
Reply #40

Vroengard

  • ****
  • Information Offline
  • Bowman
  • Posts: 424
Re: Wiki Improvement Suggestion Thread
« Reply #40 on: May 20, 2012, 12:11:15 AM »
Someone also should link texts from same cards but different versions like, Merry, Swordthain has a text (it doesnt but its an example), the tengwar or in other cases the RF versions doesnt.

May 20, 2012, 06:46:28 AM
Reply #41

Kralik

  • Guest
Re: Wiki Improvement Suggestion Thread
« Reply #41 on: May 20, 2012, 06:46:28 AM »
and 6R109 isn't even unique...

Le sigh... it's generic code.

Summary:

1) After many hours of scripting, Kralik finishes a working Autolink that takes into account various spellings, shortenings and nicknames. Over 3500 lines of regex
2) Alas! SdA deck outputs a * for unique cards in its decklists and it looks hokey.
3) Kralik adds a quick snippet to link preceding *'s. All is well in the world.

...many years pass...

4) The wiki is here!
5) Apparently wiki markup for bold doesn't play nicely with preceding stars.
6) Kralik says, "Why bother with bold anyway? This doesn't seem to be a big deal."

Someone also should link texts from same cards but different versions like, Merry, Swordthain has a text (it doesnt but its an example), the tengwar or in other cases the RF versions doesnt.

I'm not sure what you are saying. Specific example?

May 20, 2012, 06:56:47 AM
Reply #42

Kralik

  • Guest
Re: Wiki Improvement Suggestion Thread
« Reply #42 on: May 20, 2012, 06:56:47 AM »
7) Kralik removes * code anyway since it doesn't really matter. errortest is happy again.

May 20, 2012, 12:05:12 PM
Reply #43

TelTura

  • *****
  • Information Offline
  • Ranger
  • Administrator
  • Posts: 812
    • Player's Council Discord
Re: Wiki Improvement Suggestion Thread
« Reply #43 on: May 20, 2012, 12:05:12 PM »
Ah, I see now. So it was code used so that one could copy-paste the output of SDA to the forums, which then was inherited by the wiki. 

I know what pain it is to remove old code.  Your sacrifice will go down through the ages.
Come join the Player's Council to help us run events, create new cards, and steer the direction of this great game!

Join our Discord here for more information.

May 20, 2012, 12:07:17 PM
Reply #44

TelTura

  • *****
  • Information Offline
  • Ranger
  • Administrator
  • Posts: 812
    • Player's Council Discord
Re: Wiki Improvement Suggestion Thread
« Reply #44 on: May 20, 2012, 12:07:17 PM »
Also, what happened to the Lore entry of Gimli, Son of Gloin and Gimli, Son of Gloin (T)?  I haven't noticed the lore entry missing for other cards, but who knows.
Come join the Player's Council to help us run events, create new cards, and steer the direction of this great game!

Join our Discord here for more information.